Re: [PATCH] Add tests for Bitmapset

From: Greg Burd <greg(at)burd(dot)me>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: Nathan Bossart <nathandbossart(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>
Subject: Re: [PATCH] Add tests for Bitmapset
Date: 2025-09-15 18:00:18
Message-ID: F7B4253E-BE48-40E8-8624-4A791DCAA209@greg.burd.me
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On Sep 13 2025, at 10:23 am, Greg Burd <greg(at)burd(dot)me> wrote:
>
> Sawada-san, Michael,
>
> Thank you both for the push to measure.  Before the patch as it stands
> now the
> coverage for src/backend/nodes/bitmapset.c is 63.5% and after it is
> 66.5%.  Not
> an amazing difference, but something.  I guess I expected this to be
> higher given
> the degree to which this datatype is used.
>
> I'll review the gaps in coverage and update the tests.  I'll look for
> a way to add meaningful randomization.
>
> -greg

Hello hackers,

Here's the progress I've made in coverage for testing Bitmapset.

coverage: HEAD v1 v2
lines......: 87.1 87.7 91.3
functions..: 100 100 100
branches...: 63.5 66.5 77.9

I've also added a function that performs a variety of operations using
random data.

For reference radixtree has:

coverage: HEAD
lines......: 98.3
functions..: 97.2
branches...: 89.4

best,

-greg

Attachment Content-Type Size
v2-0001-Add-a-module-that-tests-Bitmapset.patch application/octet-stream 25.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2025-09-15 18:11:52 Re: Identifying function-lookup failures due to argument name mismatches
Previous Message Alexander Korotkov 2025-09-15 17:47:15 Re: Add SPLIT PARTITION/MERGE PARTITIONS commands