Re: pg_dump: fix memory leak

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Cc: m(dot)korotkov(at)postgrespro(dot)ru, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_dump: fix memory leak
Date: 2025-08-29 10:07:54
Message-ID: F60FA5E1-A42A-4E4A-AD61-A7E93B854D4A@yesql.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 29 Aug 2025, at 11:52, Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:

> Hmm, this begs the question -- why do we make generate_restrict_key()
> return NULL in that case? Maybe we should redefine its contract to be
> that it either returns a valid key, or it calls pg_fatal(). Then
> callers don't have to worry about it.

That is certainly an option.

--
Daniel Gustafsson

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2025-08-29 10:12:57 Re: Assert single row returning SQL-standard functions
Previous Message Pavel Stehule 2025-08-29 10:06:09 Re: Assert single row returning SQL-standard functions