Re: Avoid erroring out when unable to remove or parse logical rewrite files to save checkpoint work

From: "Bossart, Nathan" <bossartn(at)amazon(dot)com>
To: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Avoid erroring out when unable to remove or parse logical rewrite files to save checkpoint work
Date: 2022-01-13 19:24:15
Message-ID: F5F64689-B0A3-470E-B9B6-D73FC482FED3@amazon.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 1/12/22, 10:03 PM, "Bharath Rupireddy" <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
> On Thu, Jan 13, 2022 at 3:47 AM Bossart, Nathan <bossartn(at)amazon(dot)com> wrote:
>> The only feedback I have for the patch is that I don't think the new
>> comments are necessary.
>
> I borrowed the comments as-is from the CheckPointSnapBuild introduced
> by the commit b89e15105. IMO, let the comments be there as they
> explain why we are not emitting ERRORs, however I will leave it to the
> committer to decide on that.

Huh, somehow I missed that when I looked at it yesterday. I'm going
to bump this one to ready-for-committer, then.

Nathan

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2022-01-13 19:32:38 Re: Adding CI to our tree
Previous Message Justin Pryzby 2022-01-13 19:06:42 Re: Adding CI to our tree