Re: Improve error reporting in 027_stream_regress test

From: Brandon Tat <brandontat6(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Alexander Lakhin <exclusion(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: Improve error reporting in 027_stream_regress test
Date: 2025-12-04 07:01:31
Message-ID: F52846E6-1774-4DF6-A94C-50C98CF0B338@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Michael,

Regarding the function regression_log_helper(), this function reads all the lines in the logs at line 219 of src/test/recovery/t/027_stream_regress.pl. It seems wasteful to read the file again twice in read_file_ends(). Alternatively, we could read the file once within regression_log_helper() and index lines to emit the lines that we want.

- Brandon & Ben

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Smith 2025-12-04 07:01:56 Re: Proposal: Conflict log history table for Logical Replication
Previous Message Kirill Reshke 2025-12-04 07:00:23 Re: Fix crash during recovery when redo segment is missing