Re: [PATCH] ANALYZE: hash-accelerate MCV tracking for equality-only types

Hi,

> On May 3, 2026, at 22:16, Ilia Evdokimov <ilya(dot)evdokimov(at)tantorlabs(dot)com> wrote:
>
> I reviewed v5 of the patches. Instead of going through each issue one by one, I made a pass to clean up and clarify the code and summarize the main changes belows:
> - Fixed a few typos in comments and added comments in places where the logic was not immediately clear;
> - Rewrote the bubble-up loop using `for` loop, which I find more readable. Also removed some confusing uses of the `j` variable that mase the flow harder to follow;
> - Simplified parts of the code to improve overall readability.

Thanks for the review and for working on this.

After giving it more thought, I agree with John’s point that the set of
types benefiting from this optimization is currently too limited. While
this optimization can still provide noticeable improvements in some
specific cases, those cases do not seem common enough at this stage, so
the overall benefit also seems fairly small.

Because of that, I marked this patch as Withdrawn in the current
CommitFest and plan to pause further work on it for now.

That said, if postgres or some extensions introduce more commonly used
types that are a good fit for this optimization, I think it would make
sense to revisit and potentially revive this work.

Thanks again for the effort and contribution.

--
Best regards,
Chengpeng Yan