Re: [oauth] Increased CPU usage during device flow with libcurl 8.20.0

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: [oauth] Increased CPU usage during device flow with libcurl 8.20.0
Date: 2026-06-16 20:11:53
Message-ID: F3E25537-733E-45DD-BA21-AA43C8A837CB@yesql.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 16 Jun 2026, at 21:46, Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> wrote:

> Attached as v2-0002, which moves the version check into one of the
> OAuth test executables. (I'll hold 0004 until after REL_19_STABLE is
> branched; it just implements the v1 strategy and reverts 0002.)

+#if USE_LIBCURL
+
+/*
+ * XXX You may wonder why this test executable, which purposely does not make
+ * use of libcurl functionality, is printing out the version of Curl. This is
+ * needed to skip tests in 001_server when we see a known broken version of
+ * libcurl. (Querying the local Curl executable isn't good enough, because that
+ * may not use the same libcurl that we've been configured with.)

If there is concern over the neatness of this (long term in the backbranches,
for master it will be reverted as mentioned), I guess one option could be to
introduce a new binary, oauth_curl_version, which only prints the version and
exits instead oa adding a flag to an otherwise unrelated binary. It would add
a little compilation overhead though.

--
Daniel Gustafsson

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ilia Evdokimov 2026-06-16 20:15:51 Fold NOT IN / <> ALL expressions containing NULL to FALSE
Previous Message Tom Lane 2026-06-16 20:03:28 Re: [PATCH] Fix segmentation fault and infinite loop in jsonb_{plperl,plpython}