| From: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
|---|---|
| To: | Nikolay Samokhvalov <nik(at)postgres(dot)ai> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, pgsql-hackers mailing list <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: sequencesync worker race with REFRESH SEQUENCES |
| Date: | 2026-09-22 08:05:42 |
| Message-ID: | F37D1AD6-E45D-4F79-9326-05401B2E91AE@yandex-team.ru |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 22 Sep 2026, Nikolay Samokhvalov wrote:
> The attached patch stops the sequencesync worker in the removal loop,
I reviewed the worker stop/start interlock and reproduced the failure on
master. Your test disables the subscription without the fix and passes
with it.
I also tested REFRESH PUBLICATION removing just one of two sequences
while the worker was blocked on the publisher. The remaining sequence
reached READY, the unsubscribed local sequence kept its old value, and
table replication continued with disable_on_error = true. There were no
sequence synchronization errors.
The patch looks good.
Thank you!
Best regards, Andrey Borodin.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2026-09-22 08:12:37 | Re: Declare variable-length catalog columns as [] rather than [1] |
| Previous Message | Michael Paquier | 2026-09-22 08:00:44 | Re: [Proposal] Expose internal MultiXact member count function for efficient monitoring |