Re: pg_getaddrinfo_all() with hintp=NULL

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Sergey Tatarintsev <s(dot)tatarintsev(at)postgrespro(dot)ru>
Cc: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_getaddrinfo_all() with hintp=NULL
Date: 2025-11-11 16:23:16
Message-ID: F0184841-2D72-463A-8D0A-BCECA8DAE66F@yesql.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 10 Nov 2025, at 06:14, Sergey Tatarintsev <s(dot)tatarintsev(at)postgrespro(dot)ru> wrote:

> I'm trying to use pg_getaddrinfo_all() with NULL hints, but got segfault.
> According to man(3) getaddrinfo, hints may be passed as NULL. In this case af_family
> is equivalent to AF_UNSPEC.

Right, but pg_getaddrinfo_all isn't getaddrinfo and doesn't claim to be. Since
pg_getaddrinfo_all can return AF_UNIX as opposed to getaddrinfo, it's not clear
why hints == NULL should mean ipv4|ipv6 here.

Accepting NULL or also (subtly) breaks the API for pg_freeaddrinfo_all which is
defined to take ai_family from the hints passed to pg_getaddrinfo_all. Now,
reading the code makes it obvious that it will work anyways, but at the very
least a patch to accept a NULL hint should update the function comment for
pg_freeaddrinfo_all.

--
Daniel Gustafsson

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Joel Jacobson 2025-11-11 16:34:39 Re: Optimize LISTEN/NOTIFY
Previous Message Florin Irion 2025-11-11 16:14:42 Re: [PATCH] pg_get_domain_ddl: DDL reconstruction function for CREATE DOMAIN statement