| From: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
|---|---|
| To: | Roman Khapov <rkhapov(at)yandex-team(dot)ru> |
| Cc: | Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>, Kirill Reshke <reshkekirill(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Additional message in pg_terminate_backend |
| Date: | 2026-02-03 08:26:43 |
| Message-ID: | EFCB8B07-5BBE-40C1-9A60-CC80E25840B9@yandex-team.ru |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 3 Feb 2026, at 12:52, Roman Khapov <rkhapov(at)yandex-team(dot)ru> wrote:
>
> <v4-0001-message-in-pg_terminate_backend-and-pg_cancel_bac.patch>
Some notes on this version:
1. Did you mean BackendMsgShmemSize()?
size = add_size(size, BackendStatusShmemSize());
2. In docs:
<function>pg_cancel_backend</function> ( <parameter>pid</parameter> <type>integer</type>, <parameter>message</parameter> <type>test</type> <literal>DEFAULT</literal> <literal>''</literal> )
Did you mean <type>text</type>?
3. Windows build failed [0]
4. In src/include/utils/misc/backend_msg.c identification is backend_msg.h
Best regards, Andrey Borodin.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Corey Huinker | 2026-02-03 08:27:53 | Re: Add expressions to pg_restore_extended_stats() |
| Previous Message | Jim Jones | 2026-02-03 08:21:57 | Re: Additional message in pg_terminate_backend |