| From: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "Andres Freund" <andres(at)anarazel(dot)de>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Lyes Ameddah <lyes(dot)amd(at)gmail(dot)com> |
| Subject: | Re: Add SKIP LOCKED to VACUUM and ANALYZE |
| Date: | 2018-10-04 01:32:47 |
| Message-ID: | EF446C09-9059-44C7-9DE5-40F327AE2329@amazon.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 10/3/18, 7:10 PM, "Michael Paquier" <michael(at)paquier(dot)xyz> wrote:
> Thanks, I have committed the patch, after minor tweaks to the docs.
Thanks!
> Mainly, in the VACUUM page, I have added a mention that VACUUM ANALYZE
> can block for row sampling. I have also removed for now the set of
> recommendations the patch added, as we still gather statistics on the
> partitioned tables from the row samples gathered from the partitions, so
> recommending to list only the leaves is not completely correct either
> all the time.
Good catch. The committed version of the documentation looks good to
me.
> We could perhaps add something about such recommendations. A separate
> section covering more general things may be interesting.
Agreed, this could be a good addition to the "Notes" sections.
Nathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2018-10-04 02:30:41 | Re: SerializeParamList vs machines with strict alignment |
| Previous Message | Iwata, Aya | 2018-10-04 01:03:53 | RE: Function for listing archive_status directory |