| From: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
|---|---|
| To: | Shubham Barai <shubhambaraiss(at)gmail(dot)com> |
| Cc: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Kevin Grittner <kgrittn(at)gmail(dot)com> |
| Subject: | Re: [HACKERS] GSoC 2017: weekly progress reports (week 6) |
| Date: | 2018-03-07 12:35:13 |
| Message-ID: | EE93CDE6-36B3-488D-A341-189736A8F609@yandex-team.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-www |
Hi!
> 28 февр. 2018 г., в 22:19, Shubham Barai <shubhambaraiss(at)gmail(dot)com> написал(а):
>
> Sure. I have attached a rebased version
I've looked into the code closely again. The patch is heavily reworked since GSoC state :)
Tests are looking fine and locking is fine-grained.
But there is one thing I could not understand:
Why do we take a lock during moveRightIfItNeeded()?
This place is supposed to be called whenever page is split just before we a locking it and right after we've come to the page from parent.
Best regards, Andrey Borodin.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2018-03-07 12:41:19 | Re: Re: [HACKERS] Subscription code improvements |
| Previous Message | Daniel Gustafsson | 2018-03-07 12:23:54 | Typo in objectaccess.h prototype |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2018-03-07 14:58:51 | Re: GSoC 2017: weekly progress reports (week 6) |
| Previous Message | Andres Freund | 2018-03-02 06:29:44 | Re: GSoC 2017: weekly progress reports (week 6) |