Re: Logging corruption error codes

From: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org, Анна Крханбарова <annkpx(at)yandex-team(dot)ru>, Dmitriy Sarafannikov <dsarafan(at)yandex-team(dot)ru>
Subject: Re: Logging corruption error codes
Date: 2019-06-25 10:01:23
Message-ID: EDA8F8F2-7CD4-4E9B-A330-D439F982CE9D@yandex-team.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Hi Michael!

> 24 июня 2019 г., в 6:59, Michael Paquier <michael(at)paquier(dot)xyz> написал(а):
>> If we introduce new error code - this is, kind of, new
>> feature. Should I send it to pgsql-hackers?
>
> Yes, I don't think that new error codes would gain a back-patch.
> So discussing that on -hackers would be more adapted in my opinion.
>
> Looking at the patch you propose, I don't have an argument against
> applying what you propose FWIW. These suggestions seem sensible. But
> that's not really a bug as the code works properly even without your
> changes.

Ok, if it's not a bug, should I re-send it to pgsql-hackers@ ? Or just register on CF as a new thing...

>
> Note: the indentation of the patch is incorrect everywhere. A
> committer applying your patch would apply pgindent anyway. :)
Oh, sorry. I'm trying to write "like a code around", but do not understand clearly how pgindent formats...

Best regards, Andrey Borodin.

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Christoph Berg 2019-06-25 10:05:25 Re: Bug
Previous Message Juan José Santamaría Flecha 2019-06-25 10:00:45 Re: BUG #15858: could not stat file - over 4GB