| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Kuwamura Masaki <kuwamura(at)db(dot)is(dot)i(dot)nagoya-u(dot)ac(dot)jp>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: bug fix and documentation improvement about vacuumdb |
| Date: | 2023-09-15 08:13:10 |
| Message-ID: | EBBF8A45-D4C8-4CF4-983E-CFE12A8CA58A@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 15 Sep 2023, at 04:39, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> wrote:
> At Thu, 14 Sep 2023 07:57:57 -0700, Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote in
>> Yeah, I think we can fix the JOIN as you suggest. I quickly put a patch
>> together to demonstrate.
Looks good from a quick skim.
>> We should probably add some tests...
Agreed.
> It seems to work fine. However, if we're aiming for consistent
> spacing, the "IS NULL" (two spaces in between) might be an concern.
I don't think that's a problem. I would rather have readable C code and two
spaces in the generated SQL than contorting the C code to produce less
whitespace in a query few will read in its generated form.
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2023-09-15 08:51:44 | Re: Synchronizing slots from primary to standby |
| Previous Message | Anthonin Bonnefoy | 2023-09-15 08:04:45 | Re: POC: Extension for adding distributed tracing - pg_tracing |