Re: Identifying function-lookup failures due to argument name mismatches

From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, Dominique Devienne <ddevienne(at)gmail(dot)com>
Subject: Re: Identifying function-lookup failures due to argument name mismatches
Date: 2025-08-19 08:54:45
Message-ID: EB981B36-AE8C-471F-A395-83D6A5249D37@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Tom,

> On Aug 8, 2025, at 09:29, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Anyway, I'm not seriously proposing that this should be committed
> as-is. I'm throwing it out there in case anyone else has a good
> idea or feels motivated to push on the problem some more.

Looks like you are looking for someone to work out a final patch. If that is true, I will be happy to work on this problem.

> I couldn't quite let go of this, and after some thought I hit on the
> idea of making FuncnameGetCandidates pass back a bitmask of flags
> showing how far the match succeeded. This seems to work pretty
> nicely, allowing quite-detailed reports with only minimal added
> overhead or code restructuring. There's probably room for further
> improvement, but it has less of a whiff of "quick single-purpose
> hack". See draft commit message for more details.

I traced this problem today, and I agree that making FuncnameGetCandidates to pass out some information should be right direction to go.

When there are multiple matches, I think we can find the best match by considering argument names/types, default values. If there are still multiple best matches, I think we can prompt all matches to client.

--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ants Aasma 2025-08-19 09:09:20 Re: Speed up COPY FROM text/CSV parsing using SIMD
Previous Message vignesh C 2025-08-19 08:43:52 Re: Logical Replication of sequences