| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Christoph Berg <myon(at)debian(dot)org> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: "openssl" should not be optional |
| Date: | 2025-09-24 11:40:22 |
| Message-ID: | EB87D949-F9D4-4A8E-B003-BB0C18848F83@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 24 Sep 2025, at 13:37, Christoph Berg <myon(at)debian(dot)org> wrote:
>
> Re: Daniel Gustafsson
>> It seems a bit restrictive to require the openssl binary which is test-only,
>> since we allow building with ssl but without TAP support (which is where the
>> openssl binary is used).
>
> Ok, but then the error messages should be better. This was found
> because a fellow Debian developer was smart enough to spot the extra
> space in that " x509" error message... (And another one knew about
> this difference between the different build environments.)
If we make it optional and skip the relevant tests then there wouldn't be any
errors messages? I do agree that all messaging around should be very clear
though, so it's obvious why tests were skipped.
Do you feel like expanding your patch or should I?
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Christoph Berg | 2025-09-24 11:51:50 | Re: "openssl" should not be optional |
| Previous Message | Dilip Kumar | 2025-09-24 11:40:17 | Re: Proposal: Conflict log history table for Logical Replication |