Re: Check the fd number against FD_SETSIZE in PQsocketPoll

From: Roman Khapov <rkhapov(at)yandex-team(dot)ru>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Check the fd number against FD_SETSIZE in PQsocketPoll
Date: 2026-10-29 16:10:42
Message-ID: EA35FD13-9785-41D0-8D2F-FB3EE6A35BB0@yandex-team.ru
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>
> Patch attached: fail cleanly with EINVAL instead of corrupting the stack. This only affects platforms without poll(2) (essentially Windows and ancient Unixes?), and the

Well, testing on Windows showed that assumption was incorrect, and the
check is not needed on Windows. So now patch fixes only
the Unix without poll(2), what sounds mostly theoretical...

Anyway, attached the v2.

--
Best regards,
Roman Khapov

Attachment Content-Type Size
v2-0001-libpq-guard-select-fallback-against-fds-FD_SETSIZ.patch application/octet-stream 1.4 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Burd 2026-10-29 16:12:52 Hash index: stop registering pin-only bucket pages in WAL (remove REGBUF_NO_CHANGE)
Previous Message Salma Elsayed 2026-10-29 15:58:20 Re: CREATE TABLE .. LIKE copies comments to an unrelated table