Re: [PATCH] Fix hashed ScalarArrayOp semantics for NULL LHS with non-strict comparators

From: Chengpeng Yan <chengpeng_yan(at)outlook(dot)com>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, cca5507 <cca5507(at)qq(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: [PATCH] Fix hashed ScalarArrayOp semantics for NULL LHS with non-strict comparators
Date: 2026-04-23 05:47:01
Message-ID: E9205C03-C8F8-4835-BC31-24499ECE724F@outlook.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


> On Apr 23, 2026, at 13:32, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>
> I thought of it, but didn't do it as it meant having to keep a bit
> more state to track if we've filled the cache yet, plus the extra
> costs incurred to check if we've done it yet that would have to be
> paid for every NULL lookup. We currently have to check if the hash
> table has been set up already, so I felt more comfortable installing
> the new code in with that.

That makes sense to me. I agree that tying it to the existing hash-table
setup is the simpler place to do it, and avoids adding extra state plus
another check on each NULL lookup.

So I am fine with keeping it as-is.
--
Best regards,
Chengpeng Yan

In response to

Browse pgsql-hackers by date

  From Date Subject
Previous Message 南拓弥 2026-04-23 05:46:53 Re: Warn on missing replica identity in CREATE/ALTER PUBLICATION