Re: Rev 4704

From: "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk>
To: "Andreas Pflug" <pgadmin(at)pse-consulting(dot)de>
Cc: "pgadmin-hackers" <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Rev 4704
Date: 2005-11-09 14:02:55
Message-ID: E7F85A1B5FF8D44C8A1AF6885BC9A0E4E7DEAB@ratbert.vale-housing.co.uk
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

> -----Original Message-----
> From: Andreas Pflug [mailto:pgadmin(at)pse-consulting(dot)de]
> Sent: 09 November 2005 12:50
> To: Dave Page
> Cc: pgadmin-hackers
> Subject: Re: Rev 4704
>
> Dave Page wrote:
> >
> >
> >
> >>-----Original Message-----
> >>From: Andreas Pflug [mailto:pgadmin(at)pse-consulting(dot)de]
> >>Sent: 09 November 2005 10:20
> >>To: Dave Page; pgadmin-hackers
> >>Subject: Rev 4704
> >>
> >>Dave,
> >>
> >>I'm trying to make sense of your change of ShowTipOfTheDay's
> >>type from
> >>bool to int for 1.5. The type was changed to bool in 1.3,
> and I don't
> >>see a reason to change it again.
> >
> >
> > As we discussed last week, it causes an assert in debug builds on
> > Windows as wx seems to be unable to cast from DWORD to bool. Even
> > deleting the registry key and allowing it to recreate it
> itself doesn't
> > help.
>
> I remember seeing the msg now, but I don't see why we should
> care about
> an assert in debug builds. Just ignore it, and touch the TOTD flag.

That's the problem - touching the flag made no difference whatsoever,
and having it stop on assert every time I try to debug is really
annoying.

> I'm seeing an unconditional error msgbox right now, which is
> even more
> painful (and probably not restricted to debug build)

From what? I don't see any errors here anymore on Windows, and there's
nothing new appeared on Linux. The registry key type and on/off values
haven't changed either, so there should be no visible change.

Regards, Dave.

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message svn 2005-11-09 14:31:57 SVN Commit by andreas: r4714 - in trunk/pgadmin3: . src/include src/schema
Previous Message Andreas Pflug 2005-11-09 12:50:21 Re: Rev 4704