Re: [HACKERS] External Sort timing debug statements

> -----Original Message-----
> From: pgsql-patches-owner(at)postgresql(dot)org
> [mailto:pgsql-patches-owner(at)postgresql(dot)org] On Behalf Of Tom Lane
> Sent: 03 October 2005 15:37
> To: Simon Riggs
> Cc: pgsql-hackers(at)postgresql(dot)org; pgsql-patches(at)postgresql(dot)org
> Subject: Re: [PATCHES] [HACKERS] External Sort timing debug
> statements
>
> Simon Riggs <simon(at)2ndquadrant(dot)com> writes:
> > The following patch implements a fairly light set of timing
> statements
> > aimed at understanding external sort performance. There is
> no attempt to
> > alter the algorithms.
>
> What do people think about putting something like this into 8.1?
> Strictly speaking it's a new feature, but the patch seems pretty
> noninvasive, and we'd be much more likely to get data points if the
> code exists in the mainline release than if people have to patch
> their copies.

Agreed.

> > postgres=# set debug_sort=true;
>
> I'm a bit inclined to call it trace_sort instead, and to document it
> under "Developer Options". Comments?

Sounds reasonable to me.

Regards, Dave.