Re: row count with libpq driver

Hi Scot,

Unfortunately I've been seeing some unexplained errors with some
Microsoft ADO based apps since applying this patch, so I've backed it
out for now. Unfortunately, ADO doesn't give any useful error messages.

I'm not entirely sure what's wrong - can you look at it please? I'm
still swamped at the moment :-(

Regards, Dave

> -----Original Message-----
> From: pgsql-odbc-owner(at)postgresql(dot)org
> [mailto:pgsql-odbc-owner(at)postgresql(dot)org] On Behalf Of Dave Page
> Sent: 15 September 2005 09:12
> To: Scot Loach; pgsql-odbc(at)postgresql(dot)org
> Subject: Re: [ODBC] row count with libpq driver
>
>
>
> > -----Original Message-----
> > From: Scot Loach [mailto:sloach(at)sandvine(dot)com]
> > Sent: 15 September 2005 04:02
> > To: Dave Page; pgsql-odbc(at)postgresql(dot)org
> > Subject: RE: [ODBC] row count with libpq driver
> >
> > A patch for this is attached, please review.
>
> Thanks Scot - patch applied with a couple of minor fixes -
> specifically
>
> +#ifndef USE_LIBPQ
> + if (res->recent_processed_row_count = 0 &&
> res->ntuples > 0)
> + {
> + *pcrow = res->ntuples;
> + return SQL_SUCCESS;
> + }
> +#endif
>
> Was changed to
>
> +#ifdef USE_LIBPQ
> + if (res->recent_processed_row_count == 0 &&
> res->ntuples > 0)
> + {
> + *pcrow = res->ntuples;
> + return SQL_SUCCESS;
> + }
> +#endif
>
> Note the '#ifdef', and '== 0'
>
> Regards, Dave
>
> ---------------------------(end of
> broadcast)---------------------------
> TIP 6: explain analyze is your friend
>