Re: Lowercase folding - simple patch?

> -----Original Message-----
> From: pgsql-odbc-owner(at)postgresql(dot)org
> [mailto:pgsql-odbc-owner(at)postgresql(dot)org] On Behalf Of Marko Ristola
> Sent: 01 August 2005 17:28
> To: Merlin Moncure
> Cc: Eric E; pgsql-odbc(at)postgresql(dot)org
> Subject: Re: [ODBC] Lowercase folding - simple patch?
>
>
> Does somebody know, wether the following code is correct:
>
> odbcapi.c:
>
>
> RETCODE SQL_API
> SQLColumns(HSTMT StatementHandle, ...)
> {
> ...
>
> if (SC_is_lower_case(stmt, conn)) /* case-insensitive
> identifier */
> ifallupper = FALSE;
>
> In above there is one hidden problem:
> SC_is_lower_case() is implemented as follows:
>
> statement.h:#define SC_is_lower_case(a, b)
> (a->options.metadata_id,
> b->connInfo.lower_case_identifier)
>
>
> GCC compiler complaints (-Wall enabled) about the definition:
>
> odbcapi.c:140: warning: left-hand operand of comma expression
> has no effect
>
> So this means, that a->options.metadata_id is not used at
> all. Maybe the
> comma
> should be replaced with && or || ?

I *think* && is appropriate, however I'm too busy too look into this in
depth right now. Any chance you can confirm this?
(a->options.metadata_id is attribute SQL_ATTR_METADATA_ID btw).

Regards, Dave.