Re: --enable-thread-safety on Win32

From: "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk>
To: "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "PostgreSQL-development" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: --enable-thread-safety on Win32
Date: 2005-07-28 15:16:27
Message-ID: E7F85A1B5FF8D44C8A1AF6885BC9A0E4AC95FF@ratbert.vale-housing.co.uk
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> -----Original Message-----
> From: Bruce Momjian [mailto:pgman(at)candle(dot)pha(dot)pa(dot)us]
> Sent: 28 July 2005 16:08
> To: Tom Lane
> Cc: Dave Page; PostgreSQL-development
> Subject: Re: [HACKERS] --enable-thread-safety on Win32
>
> Tom Lane wrote:
> > "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk> writes:
> > > From: Bruce Momjian [mailto:pgman(at)candle(dot)pha(dot)pa(dot)us]
> > >> I would like to see how hard it would be to
> > >> add #ifdefs to get the test program to run on Win32.
> >
> > > I did manage to get it to compile (though not work fully
> just yet),
> > > however I had to use the full pthreads library rather
> than our minimal
> > > implementation. That's why I question whether we should
> go this way - an
> > > extra dependency (pthreads is not normally on a Windows
> box, even with
> > > Msys) to test an OS that we know 100% for sure is not
> going to vary in
> > > it's thread-safetyness(!) from system to system.
> >
> > I agree --- that seems like useless make-work. Just put a
> special case
> > for Windows into configure.in and be done with it.
>
> OK, but I would then like someone to actually run the tests we do in
> thread_test.c and make sure they _would_ pass on Win32.

OK, I will work on this, and subsequently fixing configure etc.

Regards, Dave

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2005-07-28 15:44:56 Re: [COMMITTERS] pgsql: Basic documentation for ROLEs.
Previous Message Bruce Momjian 2005-07-28 15:08:12 Re: --enable-thread-safety on Win32