Re: [PATCHES] default database creation with initdb

From: "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Andrew Dunstan" <andrew(at)dunslane(dot)net>, "Andreas Pflug" <pgadmin(at)pse-consulting(dot)de>, "Robert Treat" <xzilla(at)users(dot)sourceforge(dot)net>, "Magnus Hagander" <mha(at)sollentuna(dot)net>, <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCHES] default database creation with initdb
Date: 2005-06-21 08:16:21
Message-ID: E7F85A1B5FF8D44C8A1AF6885BC9A0E490E5CF@ratbert.vale-housing.co.uk
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> -----Original Message-----
> From: Tom Lane [mailto:tgl(at)sss(dot)pgh(dot)pa(dot)us]
> Sent: 21 June 2005 05:13
> To: Dave Page
> Cc: Andrew Dunstan; Andreas Pflug; Robert Treat; Magnus
> Hagander; pgsql-hackers(at)postgresql(dot)org
> Subject: Re: [HACKERS] [PATCHES] default database creation
> with initdb
>
> "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk> writes:
> > OK, new patch posted to -patches that updates all the
> utilities as well.
>
> Applied.

Thanks.

> Another point is that Dave added code to pg_dumpall to not dump the
> postgres database. This seems mistaken to me, so I did not include it
> in the applied patch: if someone is doing real work in postgres then
> they'll be pretty annoyed if it's not backed up. But perhaps the
> question needs debate.
>
> Any thoughts?

My reading of that code was that I merely stopped it dumping the CREATE
DATABASE statement (and the ACL) for the database, /not/ the actual
contents - in the same way as is done for template1. The theory being
that if you are reloading from into a freshing initdb'ed cluster,
postgres will already exist so doesn't need to be recreated.

Regards, Dave

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alfranio Correia Junior 2005-06-21 08:36:10 Re: HOOKS for Synchronous Replication
Previous Message Dave Page 2005-06-21 08:01:21 Re: [PATCHES] default database creation with initdb