Re: [PATCH] Repair OSX Port after i18n reorganization

From: "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk>
To: "Florian G(dot) Pflug" <fgp(at)phlo(dot)org>, "pgadmin-hackers" <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Repair OSX Port after i18n reorganization
Date: 2005-05-13 11:15:03
Message-ID: E7F85A1B5FF8D44C8A1AF6885BC9A0E490DE12@ratbert.vale-housing.co.uk
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

> -----Original Message-----
> From: pgadmin-hackers-owner(at)postgresql(dot)org
> [mailto:pgadmin-hackers-owner(at)postgresql(dot)org] On Behalf Of
> Florian G. Pflug
> Sent: 13 May 2005 10:36
> To: pgadmin-hackers
> Subject: [pgadmin-hackers] [PATCH] Repair OSX Port after i18n
> reorganization
>
> Hi
>
> This patch makes the osx build work again, by doing the following
> .) Change i18n/Makefile.am to install i18n-files into
> $(datadir)i18n instead of $(datadir)/pgadmin3/i18n when
> building an appbundle.
> .) Put the files listed in TMP_ui in i18n/Makefile.am
> into EXTRA_DIST instead. I guess this was an error,
> since TMP_ui is never used in this Makefile...
> .) Support DESTDIR in i18n/Makefile.am
> .) Moves the path-hint support for windows from
> pgAdmin3.cpp to base/appbase.cpp,
> because this saves some conditionals and is cleaner
> .) Make "path" a global variable, like loadPath, ...
>
> Now all path-related setups are done in InitPaths in AppBase

Thanks - patch applied.

> I didn't test the win32 build... I hope I didn't break anything..

Nothing another #include didn't fix :-)

Regards, Dave

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2005-05-13 11:55:32 Re: [PATCH] Appbundle-Support for 1.2
Previous Message svn 2005-05-13 11:12:03 SVN Commit by dpage: r4181 - in trunk/pgadmin3: i18n src src/agent src/base src/ctl src/include/base src/include/ctl