Re: pg_autovacuum/Win32 Fixes

> -----Original Message-----
> From: Neil Conway [mailto:neilc(at)samurai(dot)com]
> Sent: 22 January 2005 10:13
> To: Dave Page
> Cc: pgsql-patches(at)postgresql(dot)org
> Subject: Re: [PATCHES] pg_autovacuum/Win32 Fixes
>
> Dave Page wrote:
> > Theis patch supercedes *all* my earlier ones from today -
> apologies for
> > the noise, clearly I need a beer or 3 and a few nights away from the
> > laptop.
>
> @@ -1166,7 +1166,9 @@
> exit(0);
> #ifdef WIN32
> case 'E':
> - args->service_dependencies = optarg;
> + ZeroMemory(deps, sizeof(deps));
> + snprintf(deps, sizeof(deps) - 2, "%s", optarg);
> + args->service_dependencies = (char *)deps;
> break;
> case 'I':
> args->install_as_service++;
>
> After googling around I can see what this code is intended to
> do; in the
> future a comment might be nice.

Sorry - as you probably noticed it was one of 'those days'.

> Also, why not strncpy()?

No reason, just a hangover from some experimentation I was doing. I've
no objections if you want to change it.

> Barring any objections I'll apply this patch to REL8_0_STABLE
> and HEAD
> on Monday.

Thanks, Dave.