From: | "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk> |
---|---|
To: | "Andreas Pflug" <pgadmin(at)pse-consulting(dot)de> |
Cc: | "P3 Consulting" <p3c(at)p3-consulting(dot)net>, "pgadmin-hackers" <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: BUG: pgIndex.cpp |
Date: | 2005-01-12 09:33:12 |
Message-ID: | E7F85A1B5FF8D44C8A1AF6885BC9A0E452835E@ratbert.vale-housing.co.uk |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
> -----Original Message-----
> From: Andreas Pflug [mailto:pgadmin(at)pse-consulting(dot)de]
> Sent: 12 January 2005 09:27
> To: Dave Page
> Cc: P3 Consulting; pgadmin-hackers
> Subject: Re: [pgadmin-hackers] BUG: pgIndex.cpp
>
> Dave Page wrote:
>
> > Did you get a chance to look at this? It seems to me that
> the quick and
> > dirty solution is to wrap the index->iSetxxx calls in an
> 'if (index)',
> > however I'm not entirely convinced that is safe given that
> it's possible
> > to return a null index pointer to the caller (which without
> significant
> > trawling through code I may not find all instances of).
>
> I don't see the point catching this beyond an assert. A sane
> pgsql will
> never return contype != p, u, or NULL unless system tables
> are corrupted.
Very true.
Regards, Dave.
From | Date | Subject | |
---|---|---|---|
Next Message | Andreas Pflug | 2005-01-13 10:19:14 | Re: [pgadmin-support] I fixed a couple compile errors, but not all, |
Previous Message | Andreas Pflug | 2005-01-12 09:27:16 | Re: BUG: pgIndex.cpp |