| From: | "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru> |
|---|---|
| To: | Japin Li <japinli(at)hotmail(dot)com> |
| Cc: | 邱宇航 <iamqyh(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Andrey Borodin <amborodin86(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Nikolay Samokhvalov <samokhvalov(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Transaction timeout |
| Date: | 2023-12-08 10:08:12 |
| Message-ID: | E751C6BA-6885-46B7-B62D-272C2A2A923D@yandex-team.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 8 Dec 2023, at 12:59, Japin Li <japinli(at)hotmail(dot)com> wrote:
>
>
> On Thu, 07 Dec 2023 at 20:40, Andrey M. Borodin <x4mmm(at)yandex-team(dot)ru> wrote:
>>> On 7 Dec 2023, at 06:25, Japin Li <japinli(at)hotmail(dot)com> wrote:
>>>
>>> If idle_in_transaction_timeout is bigger than transaction_timeout,
>>> the idle-in-transaction timeout don't needed, right?
>> Yes, I think so.
>>
>
> Should we disable the idle_in_transaction_timeout in this case? Of cursor, I'm
> not strongly insist on this.
Good idea!
> I think you forget disable transaction_timeout in AutoVacWorkerMain().
> If not, can you elaborate on why you don't disable it?
Seems like code in autovacuum.c was copied, but patch was not updated. I’ve fixed this oversight.
Thanks!
Best regards, Andrey Borodin.
| Attachment | Content-Type | Size |
|---|---|---|
| v8-0001-Introduce-transaction_timeout.patch | application/octet-stream | 18.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2023-12-08 10:27:16 | Re: [HACKERS] make async slave to wait for lsn to be replayed |
| Previous Message | Jakub Wartak | 2023-12-08 10:02:11 | Re: trying again to get incremental backup |