Re: parse/analyze API refactoring

From: "Bossart, Nathan" <bossartn(at)amazon(dot)com>
To: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: parse/analyze API refactoring
Date: 2022-01-12 23:49:28
Message-ID: E684B0DB-2A23-4E02-80F1-C54D3856E0E6@amazon.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 12/28/21, 8:25 AM, "Peter Eisentraut" <peter(dot)eisentraut(at)enterprisedb(dot)com> wrote:
> (The "withcb" naming maybe isn't great; better ideas welcome.)

FWIW I immediately understood that this meant "with callback," so it
might be okay.

> Not included in this patch set, but food for further thought: The
> pg_analyze_and_rewrite_*() functions aren't all that useful (anymore).
> One might as well write
>
> pg_rewrite_query(parse_analyze_xxx(...))

I had a similar thought while reading through the patches. If further
deduplication isn't too much trouble, I'd vote for that.

Nathan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tatsuo Ishii 2022-01-12 23:51:01 Re: is ErrorResponse possible on Sync?
Previous Message Thomas Munro 2022-01-12 23:40:00 Re: Stream replication test fails of cfbot/windows server 2019