From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> |
Subject: | Re: Explicitly enable meson features in CI |
Date: | 2025-07-04 13:18:46 |
Message-ID: | E47BC747-B7AE-48B8-98B8-DA2023A0FB0A@yesql.se |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On 4 Jul 2025, at 09:33, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> wrote:
> On Thu, 3 Jul 2025 at 17:07, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>> An alternative approach would be to instead of having opt-in's for non-Windows
>> have opt-outs for Windows, ie a MESON_WINDOWS_EXCLUDES which does =disabled on
>> the specific features we dont want on Windows?
>
> I think this would make things complicated.
I think you're right.
> Instead, we can set
> Windows VS tasks' features in its task, then we can have a one common
> feature variable at the top level and have a comment about this
> variable not being used in the Windows VS task. Basically the same
> with your approach but instead of using a common feature variable and
> disabling features from it, we enable them again in the Windows VS
> task. I used this approach in the v3-0002.
The proposal in v3 strikes a good balance between avoiding repetition and being
readable.
--
Daniel Gustafsson
From | Date | Subject | |
---|---|---|---|
Next Message | David Steele | 2025-07-04 13:39:00 | Re: Improve verification of recovery_target_timeline GUC. |
Previous Message | Hayato Kuroda (Fujitsu) | 2025-07-04 13:01:12 | RE: Suggestion to add --continue-client-on-abort option to pgbench |