Re: GUC for temporarily disabling event triggers

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: Mikhail Gribkov <youzhick(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: GUC for temporarily disabling event triggers
Date: 2023-04-03 12:45:53
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

> On 2 Apr 2023, at 21:48, Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:

> + gettext_noop("Disable event triggers for the duration of the session."),
> Why does is it say "for the duration of the session" ?
> It's possible to disable ignoring, and within the same session.
> GUCs are typically "for the duration of the session" .. but they don't
> say so (and don't need to).
> + elog(ERROR, "unsupport event trigger: %d", event);
> typo: unsupported
> + Allows to temporarily disable event triggers from executing in order
> => Allow temporarily disabling execution of event triggers ..
> + to troubleshoot and repair faulty event triggers. The value matches
> + the type of event trigger to be ignored:
> + <literal>ddl_command_start</literal>, <literal>ddl_command_end</literal>,
> + <literal>table_rewrite</literal> and <literal>sql_drop</literal>.
> + Additionally, all event triggers can be disabled by setting it to
> + <literal>all</literal>. Setting the value to <literal>none</literal>
> + will ensure that all event triggers are enabled, this is the default
> It doesn't technically "ensure that they're enabled", since they can be
> disabled by ALTER. Better to say that it "doesn't disable any even triggers".

All comments above addressed in the attached v5, thanks for review!

Daniel Gustafsson

Attachment Content-Type Size
v5-0001-Add-GUC-for-temporarily-disabling-event-triggers.patch application/octet-stream 12.5 KB
unknown_filename text/plain 1 byte

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2023-04-03 13:09:18 Re: GUC for temporarily disabling event triggers
Previous Message Tom Lane 2023-04-03 12:40:41 Re: Sketch of a fix for that truncation data corruption issue