| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Marcos Pegoraro <marcos(at)f10(dot)com(dot)br> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: <productname> on SGML files is used for what ? |
| Date: | 2026-03-05 22:12:29 |
| Message-ID: | E227CDA9-26EE-4558-87D6-9B00DD45D62B@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 5 Mar 2026, at 19:53, Marcos Pegoraro <marcos(at)f10(dot)com(dot)br> wrote:
>
> Yesterday, Michael Paquier submitted this correction:
> Revert "Change the default value of default_toast_compression to "lz4""
> which is in the installation.sgml has:
> Build with <productname>LZ4</productname> compression support.
> But other SGML files on that commit are all using literal tag.
> So I thought, LZ4 is not a product name, so where else is this tag used ?
> And that tag is used for Kerberos, Zstandard, GSSAPI, SSPI, Windows, Oracle and others. So, there are company names, programs, protocols, utilities and others.
The DocBook manual is the main source for truth about when to use the various
tags, <productname> is documented in [1]. So Oracle is clearly a productname
if it refers to the database and not the company, but Windows should probably
use <systemitem class="osname"> [1] instead. Whether or not LZ4 is a product
name feels harder to define, but it doesn't seem entirely wrong, especially not
for the installation docs.
Mind you, we aren't using the tagging exactly according to the specification so
appropriate levels of salt should be applied, for example <application> is
meant to be used for larger software packages whereas we apply it pg_dump etc.
> Do these need to use the <literal> tag, or do we need an additional one, or perhaps a tag for each of these types ?
<literal> is IMHO great for tagging text to indicate that it is expected system
input/output or source code. Depending on context, lz4 could absolutely use
<literal> (but personally I think we should be careful to not overuse
<literal>).
--
Daniel Gustafsson
[0] https://tdg.docbook.org/tdg/5.0/productname.html
[1] https://tdg.docbook.org/tdg/5.0/systemitem.html
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sami Imseih | 2026-03-05 22:25:57 | Re: [BUG + PATCH] DSA pagemap out-of-bounds in make_new_segment odd-sized path |
| Previous Message | Andrew Dunstan | 2026-03-05 22:09:09 | Re: finish TODOs in to_json_is_immutable, to_jsonb_is_immutable also add tests on it |