| From: | Daniel Gustafsson <dgustafsson(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: doc: Fix description of relative extension "directory" setting |
| Date: | 2026-11-20 21:05:41 |
| Message-ID: | E1xUVng-00000000YlH-0c6q@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
doc: Fix description of relative extension "directory" setting
Commit 81eaaa2c4 changed the documentation of the 'directory' control
file parameter to say that a relative path is resolved against the
directory where the control file was found. That is not what the code
does: a relative path is resolved against the base directory, i.e.,
the parent of the 'extension' directory in which the primary control
file was found (SHAREDIR or the corresponding extension_control_path
element). This is what the test_extensions TAP test expects, and it
keeps the long-standing convention of "directory = 'extension/foo'"
(with MODULEDIR) working.
Restore the pre-18 wording, extended to cover extension_control_path,
and mention in the description of extension_control_path that the
'directory' setting can cause script files to be loaded from somewhere
other than the control file's directory.
Backpatch to 18, where the incorrect wording was introduced.
Author: Mahendrakar Srinivasarao <mahendrakarforpg(at)gmail(dot)com>
Reviewed-by: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Reviewed-by: Matheus Alcantara <matheusssilv97(at)gmail(dot)com>
Discussion: https://postgr.es/m/CABkiuWpGiLzDg4D8zRBJ6DHnwYgHqkFxz2gDstXgeOdzh6bdZQ@mail.gmail.com
Backpatch-through: 18
Branch
------
REL_19_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/60e0ccfaef3c09b660218b4053daf0e7b177aab3
Modified Files
--------------
doc/src/sgml/config.sgml | 4 +++-
doc/src/sgml/extend.sgml | 9 ++++++---
2 files changed, 9 insertions(+), 4 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2026-11-20 21:05:58 | pgsql: doc: Fix description of relative extension "directory" setting |
| Previous Message | Daniel Gustafsson | 2026-11-20 21:04:32 | pgsql: doc: Fix description of relative extension "directory" setting |