| From: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Avoid overflow computing visibility map length |
| Date: | 2026-11-19 22:16:15 |
| Message-ID: | E1xUAQQ-00000000RBb-1KKK@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Avoid overflow computing visibility map length
Computing the number of visibility map blocks used addition-based
ceiling division on a BlockNumber. For heap lengths near MaxBlockNumber
on 32-bit builds, the addition could overflow and produce a much smaller
visibility map length, potentially zero.
Use quotient and remainder instead so the calculation cannot overflow.
Reported-by: Melanie Plageman <melanieplageman(at)gmail(dot)com>
Author: Melanie Plageman <melanieplageman(at)gmail(dot)com>
Reviewed-by: shihao zhong <zhong950419(at)gmail(dot)com>
Backpatch-through: 17
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/0bfb84006e3ef2f6826e91e374b5379cc4d4a481
Modified Files
--------------
src/backend/access/heap/visibilitymap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Melanie Plageman | 2026-11-19 22:17:09 | pgsql: Avoid overflow computing visibility map length |
| Previous Message | Melanie Plageman | 2026-11-19 21:21:13 | pgsql: Fix WAL-logged CREATE DATABASE with nonstandard pages |