| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Fix setting skip_fsync on temp tables |
| Date: | 2026-11-19 12:49:01 |
| Message-ID: | E1xU1ZU-00000000Nqx-0yWW@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix setting skip_fsync on temp tables
The intention was to always skip fsync for temporary relations, but
the condition was inverted, so skip_fsync was set to false for
temporary relations. This has no user-visible effect at the moment,
because the skip_fsync field isn't used anywhere (only reads go
through AIO currently).
While here, fix a copy-pasto in the smgrwritev() comment, which said
"read" where it meant "written".
Author: Sergey Shinderuk <s(dot)shinderuk(at)postgrespro(dot)ru>
Reviewed-by: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Reviewed-by: Yuefei Shi <shiyuefei1004(at)gmail(dot)com>
Discussion: https://www.postgresql.org/message-id/A96F1990-57F8-4566-B55D-43D6087EE313@postgrespro.ru
Backpatch-through: 18
Branch
------
REL_19_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/67ad2443f78e4a7ddbefe270aa6bcd06925453d1
Modified Files
--------------
src/backend/storage/smgr/smgr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2026-11-19 14:16:38 | pgsql: psql: Replace cancel_pressed with CancelRequested |
| Previous Message | Dean Rasheed | 2026-11-19 12:38:23 | pgsql: Fix varnullingrels in MERGE into trigger-updatable view. |