pgsql: Fix pgstattuple_approx handling of unknown tuple estimates

From: Melanie Plageman <melanieplageman(at)gmail(dot)com>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix pgstattuple_approx handling of unknown tuple estimates
Date: 2026-11-18 16:02:36
Message-ID: E1xTi7H-00000000GJx-08ug@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix pgstattuple_approx handling of unknown tuple estimates

vac_estimate_reltuples() can return -1 when there is not enough
information to estimate the number of live tuples. pgstattuple_approx()
assigned that value to an unsigned counter before attempting to clamp
it, making the clamp ineffective and exposing -1 through the bigint
result.

Clamp the signed estimate before assigning it to the unsigned counter.

Reported-by: Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>
Author: Melanie Plageman <melanieplageman(at)gmail(dot)com>
Reviewed-by: Lukas Fittl <lukas(at)fittl(dot)com>
Reviewed-by: Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>
Discussion: https://postgr.es/m/CAN4CZFM0y8t%2BAQ8PWTeuBXnFtRDUNvkfVzzA_yo6uJ2bceK%3DxA%40mail.gmail.com
Backpatch-through: 15

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/33ac2b000eaba9664c9c8fa7397629ac59c44dc8

Modified Files
--------------
contrib/pgstattuple/expected/pgstattuple.out | 12 ++++++++++++
contrib/pgstattuple/pgstatapprox.c | 9 +++++----
contrib/pgstattuple/sql/pgstattuple.sql | 10 ++++++++++
doc/src/sgml/pgstattuple.sgml | 3 ++-
4 files changed, 29 insertions(+), 5 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Dean Rasheed 2026-11-18 16:05:53 pgsql: Fix transition tables for MERGE with cross-partition UPDATEs.
Previous Message Melanie Plageman 2026-11-18 15:58:54 pgsql: Fix pgstattuple_approx handling of unknown tuple estimates