pgsql: Fix handling of backend crashes during standby promotion

From: Fujii Masao <fujii(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix handling of backend crashes during standby promotion
Date: 2026-11-18 04:32:08
Message-ID: E1xTXL5-00000000Bfk-07Nd@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix handling of backend crashes during standby promotion

If a backend crashed as a standby finishes promotion, the server could
resume normal operation without resetting shared memory and performing
crash recovery. With restart_after_crash disabled, it could keep running
instead of shutting down as required.

This happened when the postmaster detected the backend crash and sent
SIGQUIT to the startup process, but that process had already exited or
was too far along in its normal exit sequence to respond to the signal.
The postmaster then treated its zero exit status as successful startup,
clearing FatalError and entering PM_RUN despite the backend crash.

Fix this by honoring STARTUP_SIGNALED even when the startup process
exits with status zero. This lets the postmaster finish handling
the crash and either restart or shut down, according to restart_after_crash.

A failure of 041_checkpoint_at_promote.pl on buildfarm member tamandua
exposed this race in the server's handling of backend crashes. Although
the test was introduced in v17, the bug affects all supported versions.

Backpatch to all supported versions.

Reported-by: Alexander Lakhin <exclusion(at)gmail(dot)com>
Author: Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com>
Reviewed-by: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Discussion: https://postgr.es/m/1c733765-62af-48b3-b0d7-1e744c8b8522@gmail.com
Backpatch-through: 15

Branch
------
REL_19_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/63df88f3ab9c185d8a382f4cec6132123e45a85c

Modified Files
--------------
src/backend/postmaster/postmaster.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Fujii Masao 2026-11-18 04:32:19 pgsql: Stop WAL streaming on timeline history file write failures
Previous Message Fujii Masao 2026-11-18 04:32:07 pgsql: Stop WAL streaming on timeline history file write failures