| From: | Fujii Masao <fujii(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: doc: Explain that ANALYZE ignores reject_limit in file_fdw |
| Date: | 2026-11-11 01:07:46 |
| Message-ID: | E1xQwoU-00000000FHA-1TQh@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
doc: Explain that ANALYZE ignores reject_limit in file_fdw
The documentation did not explain that ANALYZE on file_fdw foreign tables
ignores reject_limit, which could lead users to expect it to fail when
the number of skipped rows exceeded the limit.
Ignoring the limit allows statistics to be collected from valid rows
even when the limit is exceeded. These statistics can still be useful for
queries using LIMIT, for example, which may finish before encountering
enough conversion errors to exceed reject_limit.
Document this exception and its rationale.
Backpatch to v18, where reject_limit support was added to file_fdw.
Author: Ayoub Kazar <ayoub(dot)kazar(at)data-bene(dot)io>
Reviewed-by: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Discussion: https://postgr.es/m/6cc479df-7571-4393-a572-f46dba1bfcbf@data-bene.io
Backpatch-through: 18
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/0b355d4277e76d6ae691855070e20da703789cea
Modified Files
--------------
contrib/file_fdw/file_fdw.c | 6 +++++-
doc/src/sgml/file-fdw.sgml | 5 ++++-
2 files changed, 9 insertions(+), 2 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2026-11-11 01:08:21 | pgsql: doc: Explain that ANALYZE ignores reject_limit in file_fdw |
| Previous Message | Fujii Masao | 2026-11-11 00:54:33 | pgsql: doc: Remove incorrect libpq environment reference from pg_combin |