pgsql: Simplify leader error reporting for parallel apply worker failur

From: Amit Kapila <akapila(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Simplify leader error reporting for parallel apply worker failur
Date: 2026-11-10 08:24:42
Message-ID: E1xQh9m-000000009wD-0zo2@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Simplify leader error reporting for parallel apply worker failures.

When a parallel apply worker failed, the leader copied the worker's error
context into its own error and appended the context of whatever it was
applying at that moment. The failed transaction was thus logged twice,
and the log read as if both contexts belonged to the same transaction.

The worker has already logged its error with the context of the failed
transaction. Have the leader report only that the worker exited due to an
error, using its own error context.

Author: Hayato Kuroda <kuroda(dot)hayato(at)fujitsu(dot)com>
Author: vignesh C <vignesh21(at)gmail(dot)com>
Reviewed-by: Zhijie Hou <houzhijie22(at)gmail(dot)com>
Reviewed-by: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
Reviewed-by: Ajin Cherian <itsajin(at)gmail(dot)com>
Reviewed-by: Takeshi Ideriha <iderihatakeshi(at)gmail(dot)com>
Reviewed-by: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Discussion: https://postgr.es/m/CALDaNm0SSCS5EJ_KNXau_3iCr_KrpKth=ZrTeOf1DCFbE=3=9w@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/952bab8b74d40fcfd25e1949865c3907e676504e

Modified Files
--------------
.../replication/logical/applyparallelworker.c | 46 +++++++---------------
1 file changed, 15 insertions(+), 31 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message noreply 2026-11-10 21:03:57 pgsql: Tag refs/tags/REL_16_16 was created
Previous Message Etsuro Fujita 2026-11-10 06:16:57 pgsql: Improve comments for ExecAppendAsyncEventWait.