pgsql: Align REASSIGN OWNED caller-privilege checks with ALTER ... OWNE

From: Noah Misch <noah(at)leadboat(dot)com>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Align REASSIGN OWNED caller-privilege checks with ALTER ... OWNE
Date: 2026-11-09 14:22:04
Message-ID: E1xQQG4-000000003q5-3TSp@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Align REASSIGN OWNED caller-privilege checks with ALTER ... OWNER TO.

Commit 3d14e171e9e2236139e8976f3309a588bcc8683b (v16) made giving an
object to another role depend on the ability to SET ROLE to that role.
However, a role granted "INHERIT TRUE, SET FALSE" could bypass that, via
REASSIGN OWNED. A role granted "INHERIT FALSE, SET TRUE" saw the
inverse problem: REASSIGN OWNED failed spuriously, while ALTER ... OWNER
succeeded.

For avoidance of doubt, fixing this doesn't change the limitations of
SET FALSE. If a role owns nothing, SET FALSE grantees can't make that
role own its first object. For many kinds of objects, once a role owns
one, "INHERIT TRUE, SET FALSE" prevents nothing compared to "INHERIT
TRUE, SET TRUE".

REASSIGN OWNED also bypassed the CREATEDB privilege check in ALTER
DATABASE ... OWNER TO. Fix by duplicating the check. This affects all
supported versions. This sort of omission remains easy to miss under
the present design, so refactoring would be prudent.

Document the way REASSIGN OWNED still differs from ALTER ... OWNER TO:
the new owner's CREATE privilege on the schema of a relation or type is
not checked.

Back-patch to v14 (all supported versions). In v15 and v14, REASSIGN
OWNED's privs checks is stricter than the membership checks in ALTER
... OWNER TO. Leave that alone, rather than aligning the commands. Do
fix the CREATEDB omission.

Reported-by: Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>
Author: Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>
Backpatch-through: 14
Security: CVE-2026-120146

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/0b8d1768f2def0800b651aee63447aea79b1493d

Modified Files
--------------
doc/src/sgml/ref/reassign_owned.sgml | 7 +++++--
src/backend/catalog/pg_shdepend.c | 33 ++++++++++++++++++++++++++++---
src/backend/commands/user.c | 10 ++--------
src/test/regress/expected/create_role.out | 3 +++
src/test/regress/expected/database.out | 19 ++++++++++++++++++
src/test/regress/expected/dependency.out | 3 +--
src/test/regress/sql/create_role.sql | 2 ++
src/test/regress/sql/database.sql | 12 +++++++++++
8 files changed, 74 insertions(+), 15 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Noah Misch 2026-11-09 14:22:05 pgsql: Introduce attribute versioning to prevent unsafe deforming
Previous Message Noah Misch 2026-11-09 14:22:03 pgsql: Check table ownership when DROP OWNED BY changes policies.