pgsql: Fix type confusion with materialized set-returning functions

From: Noah Misch <noah(at)leadboat(dot)com>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix type confusion with materialized set-returning functions
Date: 2026-11-09 14:21:55
Message-ID: E1xQQFv-000000003XO-3twj@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix type confusion with materialized set-returning functions

Set-returning functions in the target list with indeterminate RECORD
return types incorrectly used the same tuple descriptor to read and
return tuples from the tuplestore across invocations.

These types of SRFs resolve their rowtype from the passed in record
argument and it can differ from invocation to invocation. Reading tuples
with the wrong shape of tuple descriptor can lead to incorrect results,
crashes, and security issues. It was reported as a way to read arbitrary
out-of-line values via json_populate_recordset().

To fix this, drop and recreate the slot and its tuple descriptor per SRF
invocation for materialized SRFs in the target list with dynamic RECORD
return types.

Only the target-list path is affected: table functions in FROM validate
every result against the query-supplied descriptor, and value-per-call
SRFs never retain a slot.

Co-authored-by: Melanie Plageman <melanieplageman(at)gmail(dot)com>
Co-authored-by: Robert Haas <rhaas(at)postgresql(dot)org>
Security: CVE-2026-120141
Backpatch-through: 14

Branch
------
REL_19_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c5dc8b0a0214fbb6d3ac71f811cb6f58e36baaa2
Author: Robert Haas <rhaas(at)postgresql(dot)org>

Modified Files
--------------
src/backend/executor/execSRF.c | 59 ++++++++++++++++++++++++++++++++------
src/test/regress/expected/json.out | 11 +++++++
src/test/regress/sql/json.sql | 5 ++++
3 files changed, 67 insertions(+), 8 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Noah Misch 2026-11-09 14:21:56 pgsql: Add tests for row type changes causing issues
Previous Message Noah Misch 2026-11-09 14:21:54 pgsql: Check for Consts in domain DEFAULTs