pgsql: Fix use-after-free in pg_show_all_settings().

From: Noah Misch <noah(at)leadboat(dot)com>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix use-after-free in pg_show_all_settings().
Date: 2026-11-09 14:21:54
Message-ID: E1xQQFu-000000003Tw-1t8q@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix use-after-free in pg_show_all_settings().

Commit 3057465acfbe changed show_all_settings(), used by the
pg_show_all_settings() SQL function, to collect pointers to all GUC
entries on its first call and return one row per call from that saved
array. When a module is loaded while the scan is still in progress,
the placeholder entries for that module's prefix are replaced and
freed, while the saved array keeps pointing at them. That caused a
use-after-free. Depending on what reused the freed chunk, the scan
returns stale rows or the backend crashes.

Fix this by using the materialize mode for show_all_settings() so that
the GUC array is consumed before any other expression in the query can
run and free an entry. This is also how the sibling function
show_all_file_settings() already works. We only have a few hundred
GUCs in practice, so materializing them all is acceptable.

Backpatch to v16, where that commit first appeared. On v15 and
earlier show_all_settings() reads each GUC entry by number on every
call and never keeps a pointer across calls, so it is not affected.

Reported-by: Stephan Lipp <Stephan(at)Adalogics(dot)com>
Reviewed-by: Greg Burd <greg(at)burd(dot)me>
Backpatch-through: 16
Security: CVE-2026-120152

Branch
------
REL_19_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/369fe93c0558acb25fa51761d697ae38047c1b40
Author: Masahiko Sawada <msawada(at)postgresql(dot)org>

Modified Files
--------------
src/backend/utils/misc/guc_funcs.c | 120 ++++++++-----------------------------
1 file changed, 24 insertions(+), 96 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Noah Misch 2026-11-09 14:21:55 pgsql: Forbid changing type if the rowtype is used in a foreign table
Previous Message Noah Misch 2026-11-09 14:21:53 pgsql: Check EXECUTE privilege on type-to-json cast functions.