pgsql: Avoid duplicate file references in backend .pot file

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Avoid duplicate file references in backend .pot file
Date: 2026-11-08 08:28:24
Message-ID: E1xPyGG-00000000gfP-35XN@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Avoid duplicate file references in backend .pot file

The list of files for the backend's message catalog is collected with
find, which also listed symlinks, namely the generated files that are
linked from src/include/utils/ to src/backend/utils/ (such as
guc_tables.inc.c) and the port/pg_sema.c and port/pg_shmem.c links
created by configure. Since the link targets are found under their
real names as well, xgettext processed those files twice, resulting in
duplicate "#:" references like

#: ../include/utils/guc_tables.inc.c:410 utils/guc_tables.inc.c:410

Fix by restricting find to regular files.

Reviewed-by: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Reviewed-by: Jonathan Gonzalez V. <jonathan(at)abdiel(dot)eu>
Discussion: https://www.postgresql.org/message-id/flat/15b90fcc-cf6e-492d-82a4-29739b2c040f%40eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d0a4f66217c8ced61c6e55486d8291edd1931eb1

Modified Files
--------------
src/backend/nls.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2026-11-08 21:30:26 pgsql: Fix more issues with extended statistics on expressions
Previous Message Magnus Hagander 2026-11-07 12:02:18 Re: pgsql: ci: Enable PCH in mingw cross job