| From: | Fujii Masao <fujii(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: file_fdw: Fix ANALYZE crashes with DEFAULT markers |
| Date: | 2026-11-06 14:34:58 |
| Message-ID: | E1xPL1u-00000000TQr-1QXI@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
file_fdw: Fix ANALYZE crashes with DEFAULT markers
ANALYZE on a file_fdw foreign table failed an assertion when the input
contained a DEFAULT marker, and could crash in builds without assertions.
This happened because the sampling code passed a NULL ExprContext to
NextCopyFrom(), which requires one to evaluate column defaults. Fix
this by providing an expression context for sampling, allowing defaults
to be evaluated without assertion failures or crashes.
Backpatch to v16, which introduced DEFAULT marker support.
Author: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Reviewed-by: Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>
Reviewed-by: Ayoub Kazar <ayoub(dot)kazar(at)data-bene(dot)io>
Reviewed-by: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Discussion: https://postgr.es/m/CAHGQGwGwihFV9FmfSbbrMsEr4fti7aHZFkpyMv5-byjfc2EmOw@mail.gmail.com
Backpatch-through: 16
Branch
------
REL_16_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/e9c45974adb439fcc6fee6175e11f92619fc5361
Modified Files
--------------
contrib/file_fdw/expected/file_fdw.out | 10 ++++++++++
contrib/file_fdw/file_fdw.c | 24 +++++++++++++-----------
contrib/file_fdw/sql/file_fdw.sql | 5 +++++
3 files changed, 28 insertions(+), 11 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2026-11-06 17:00:56 | Re: pgsql: ci: Enable PCH in mingw cross job |
| Previous Message | Fujii Masao | 2026-11-06 14:34:48 | pgsql: file_fdw: Fix ANALYZE crashes with DEFAULT markers |