| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Clean up code comments for pg_wchar_tbl |
| Date: | 2026-11-03 10:06:59 |
| Message-ID: | E1xOBPv-000000000IU-3kn2@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Clean up code comments for pg_wchar_tbl
The documentation for the functions in the fields of pg_wchar_tbl was
spread out all over the place and was missing a lot of detail. Move
and expand this at the definition of the struct. (See also struct
TableAmRoutine in access/tableam.h for inspiration.)
Also remove unnecessary typedefs, except where they were used
elsewhere as well. This indirection makes the code documentation
harder to follow. And some of those typedefs had nonsensical names,
like *_converter for functions that didn't do any converting.
Reviewed-by: Greg Burd <greg(at)burd(dot)me>
Discussion: https://www.postgresql.org/message-id/flat/637d73f4-e088-4ead-b9e6-1ddb4cd4693f%40eisentraut.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/3ba886b35a2804dcd275868a19135a31ceb81386
Modified Files
--------------
src/backend/utils/mb/mbutils.c | 10 ++--
src/common/wchar.c | 66 +++------------------
src/include/mb/pg_wchar.h | 125 ++++++++++++++++++++++++++++++++-------
src/tools/pgindent/typedefs.list | 8 +--
4 files changed, 117 insertions(+), 92 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2026-11-03 13:28:32 | pgsql: Remove git-external-diff from tools directory |
| Previous Message | Fujii Masao | 2026-11-03 06:08:02 | pgsql: doc: Fix column name in routine_sequence_usage documentation |