pgsql: Remove unwarranted Assert in dependencies_clauselist_selectivity

From: David Rowley <drowley(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Remove unwarranted Assert in dependencies_clauselist_selectivity
Date: 2026-10-30 02:31:53
Message-ID: E1xMcPJ-00000001L0O-47dW@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove unwarranted Assert in dependencies_clauselist_selectivity()

The loop above from where the Assert is removed handles assigning the same
attnum to any duplicate expressions, so asserting there are no duplicate
attnums just after purposefully making duplicate ones isn't the correct
thing to do.

The Assert was added by a4d75c86bf, so backpatch to v14

Author: BHUVAN CHILUKUTI <c(dot)bhuvan(at)iitg(dot)ac(dot)in>
Reviewed-by: David Rowley <dgrowleyml(at)gmail(dot)com>
Discussion: https://postgr.es/m/PN0P287MB0903563C70D8E5B81912E855A7602@PN0P287MB0903.INDP287.PROD.OUTLOOK.COM
Backpatch-through: 14

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/d4a81ec05ee1bc197c780092e8cc2b41ff7fcbd9

Modified Files
--------------
src/backend/statistics/dependencies.c | 11 -----------
1 file changed, 11 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message David Rowley 2026-10-30 02:32:03 pgsql: Remove unwarranted Assert in dependencies_clauselist_selectivity
Previous Message David Rowley 2026-10-30 02:31:43 pgsql: Remove unwarranted Assert in dependencies_clauselist_selectivity