pgsql: test_custom_stats: Stabilize test for counters

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: test_custom_stats: Stabilize test for counters
Date: 2026-10-18 22:09:30
Message-ID: E1xIZ4M-00000002AuH-2TvF@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

test_custom_stats: Stabilize test for counters

After 44539786b82, variable-sized stats updates are batched in one
backend. A later safe_psql() can check the counters before that backend
has finished flushing its pending stats during shutdown, so force a
flush before checking them.

This is only needed before this report check because
test_custom_stats_var_update() uses pgstat_prep_pending_entry(), leaving
counter updates as backend-local pending stats.

Per buildfarm member mamba. This could be reproduced locally by slowing
down pgstat_shutdown_hook().

Reported-by: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Author: Sami Imseih <samimseih(dot)pg(at)gmail(dot)com>
Discussion: https://postgr.es/m/193326.1792282194@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8afc886831bc629e524cc7185b2fdc0092aecc93

Modified Files
--------------
src/test/modules/test_custom_stats/t/001_custom_stats.pl | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2026-10-18 22:35:21 pgsql: libpq: Revert the connection option "servicefile"
Previous Message Peter Geoghegan 2026-10-17 15:04:20 pgsql: Fix nbtree unsatisfiable row compare assertion failure.