| From: | Amit Langote <amitlan(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Remove RI fast-path code for calling cast functions |
| Date: | 2026-10-15 08:06:29 |
| Message-ID: | E1xHGTt-00000001hxQ-2Cc9@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Remove RI fast-path code for calling cast functions
The previous commit stopped using the fast path when FK values need a
cast function, which leaves its code for calling them unused. So
remove the following: the cached FmgrInfos for the cast and equality
functions and the memory context they used, the cast step in
build_index_scankeys(), the EXECUTE privilege check on the cast
function, and the unused forward declaration of RI_CompareHashEntry.
Also revert the changes made to ri_HashCompareOp() for the fast path's
cross-type operators and domain-typed keys in commits 2da86c1ef9 and
68ace967c1. Fast-path code no longer uses the function.
Reviewed-by: Matheus Alcantara <matheusssilv97(at)gmail(dot)com>
Discussion: https://postgr.es/m/CAM527d9BgPjeOOYmbCBTd57R145qHCk-dzw9qNq+nOrDq1j__A@mail.gmail.com
Backpatch-through: 19
Branch
------
REL_19_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/2e42f11b6c883bf43cdd6d3329f3025e7096ca38
Modified Files
--------------
src/backend/utils/adt/ri_triggers.c | 137 ++++++++++--------------------------
1 file changed, 39 insertions(+), 98 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2026-10-15 08:06:43 | pgsql: Remove RI fast-path code for calling cast functions |
| Previous Message | Amit Langote | 2026-10-15 07:34:58 | pgsql: Use SPI for RI checks whose FK values need a cast function |