| From: | Robert Haas <rhaas(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: pg_plan_advice: Don't suppress NO_GATHER advice for parent rels. |
| Date: | 2026-10-09 17:13:37 |
| Message-ID: | E1xFEA5-00000000yIW-494w@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
pg_plan_advice: Don't suppress NO_GATHER advice for parent rels.
When a table is partitioned, the previous code did not emit NO_GATHER
advice for the parent table, on the theory that doing this for the
child tables was good enough. However, it isn't. I believe what
happened here is that, during development, I was planning to enforce
NO_GATHER by clearing the consider_parallel flag for the children,
which would have been good enough to ensure that parallelism could
not be used at any higher level of the plan tree. Eventually, I
switched course, but failed to realize that this code needed to be
updated as a result. Do that, and add a regression test.
Backpatch-through: 19
Discussion: http://postgr.es/m/CA+TgmoYYHC4i-Gpzc9-JYHqih6pOK+6LTYFiNR-PioXG1nKkOQ@mail.gmail.com
Branch
------
REL_19_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/13cd2227c0170f2760c4a79821e2c285171dd57f
Modified Files
--------------
contrib/pg_plan_advice/expected/gather.out | 66 +++++++++++++++++++
contrib/pg_plan_advice/expected/partitionwise.out | 78 ++++++++++++-----------
contrib/pg_plan_advice/pgpa_scan.c | 7 +-
contrib/pg_plan_advice/sql/gather.sql | 26 ++++++++
4 files changed, 135 insertions(+), 42 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2026-10-09 18:14:28 | pgsql: pg_plan_advice: Fix advice feedback JOIN_ORDER over a single sub |
| Previous Message | Daniel Gustafsson | 2026-10-09 11:43:31 | pgsql: Fix detection of truncated compressed backups |