| From: | Jacob Champion <jchampion(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: oauth_validator: Remove racing GUC check |
| Date: | 2026-10-08 18:02:22 |
| Message-ID: | E1xEsRi-00000000qLm-0bQh@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
oauth_validator: Remove racing GUC check
Follow-up to bca67e5a3. The test added there changed the value of
oauth_validator_libraries, waited for the postmaster to apply it, and
verified the change on an existing background connection. But there's no
guarantee that the SIGHUP will have arrived and completed its work on
existing backends by that time, so the final test flaked.
We only care about the postmaster's state here, since we're testing the
GUC's effects on newly forked backends, so remove the background check
entirely.
Per buildfarm member serinus.
Reported-by: Alexander Lakhin <exclusion(at)gmail(dot)com>
Discussion: https://postgr.es/m/a37a3cea-5bd8-4385-a1d4-bb89394c079c%40gmail.com
Backpatch-through: 18
Branch
------
REL_19_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/08f24a1152c264882209e5e555e1bfa14b11ad84
Modified Files
--------------
src/test/modules/oauth_validator/t/001_server.pl | 2 --
1 file changed, 2 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | Andrew Dunstan | 2026-10-08 17:41:25 | pgsql: COPY TO FORMAT JSON: use the query's column names as keys |