pgsql: Fix lcov duplicate directory specification in non-VPATH builds.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix lcov duplicate directory specification in non-VPATH builds.
Date: 2026-10-03 18:45:02
Message-ID: E1xD4jG-00000000BKn-2JHO@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix lcov duplicate directory specification in non-VPATH builds.

In an in-tree build, "make coverage-html" invoked lcov with two
"-d ." options, because $(srcdir) is just ".". With lcov 2.0
(and perhaps earlier versions?) that results in scanning every
foo.gcda file twice and producing counts twice what they should
be. With later lcov versions (at least 2.3), it results in
"duplicate file" errors.

In VPATH builds we do need two -d options to cover both regular
and generated .c files. But in in-tree builds it suffices to
specify "-d .", so suppress the second switch.

Author: Narek Galstyan <narek(dot)galstyan(at)enterprisedb(dot)com>
Reviewed-by: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Discussion: https://postgr.es/m/CAHsn6_xCDQWe8_vVFhtFk27_xTdyVV+Dr0yWzaooBZ6+-VH-5w@mail.gmail.com
Backpatch-through: 14

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/e299fc2b30f9f58691aa0782f6bc3ae3fd9f1f52

Modified Files
--------------
src/Makefile.global.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2026-10-03 21:27:59 pgsql: Map pg_attribute_counted_by() to _Field_size_() under MSVC
Previous Message Álvaro Herrera 2026-10-03 11:07:09 pgsql: Clear out values from dropped columns during REPACK (CONCURRENTL